phax/ph-css

:host and ::slotted parsing sort of wrong

shagkur opened this issue · 6 comments

This is a follow up issue to the recently merged PR.
I figured that

(<S>)*
( simpleSelectorSequence() )? 

is not correct.
It should rather be

(<S>)*
( simpleSelectorSequence() (<S>)* )* 

see: https://developer.mozilla.org/en-US/docs/Web/CSS/::slotted

Although i'm not quite sure about the trailing ()* here. WDYT?

I'll file a PR soonish

phax commented

No need to PR - thx

Sorry if i messed this up with my previous PR

phax commented

No worries - all good

phax commented

I needed to change the members types of the selectors in CSSSelectorMemberSlotted and CSSSelectorMemberHost - but that should be no big deal

Thanks alot for your quick response on this :) Very appreciated :)

phax commented

Fixed in 6.4.2