phenixdigital/phoenix_storybook

Export formatter rules for `live_storybook/2`

LostKobrakai opened this issue · 7 comments

The router macro shouldn't have parentheses added, similar to e.g. live_dashboard

I'm not sure what you mean.
Is this related to mix format locals_without_parens option?

can you have a quick look at #351 I just opened?

That's a different thing. I meant phoenix_storybook should export locals_without_parens settings for live_storybook router macro.

got it, both actually make sense.
but it seems that live_dashboard isn't exporting anything related to their router macro 🤔

https://github.com/phoenixframework/phoenix_live_dashboard/blob/main/.formatter.exs

Yeah, phoenix does however: https://github.com/phoenixframework/phoenix/blob/main/.formatter.exs#L74-L75 Not sure exactly why they do it that way, but they do.

good catch!
I should ask them to add phoenix_storybook 😛
(I will amend my PR with the locals_without_parens export)