Remove the guzzle 3 dependency
Opened this issue · 4 comments
As I discovered in the Phergie-irc-bot-rect issue 46, we had a nested dependency on old guzzle.
This was coming via a dependency on satooshi/php-coveralls requires guzzle/guzzle (version 3), which has gone away. Versions of satooshi/php-coveralls >=1.0.0 updates to Guzzle version 6 (guzzlehttp/guzzle).
I propose we update the version of php-coveralls in this package.
it looks like codeclimate's php-test-reporter locks us to satooshi/php-coveralls 0.6.0
This means as long as we want php-test-reporter, we're stuck with this warning and using guzzle version 3. That's probably OK for now.
@elstamey is this merged and fixed?
It depends on what you want/mean by fixed. Both satooshi/coveralls and php-test-reporter were calling for guzzle/guzzle which was renamed to guzzlehttp/guzzle We removed the satooshi/coveralls dependency, and they still haven't tagged a new version or revision. But I haven't kept up with php-test-reporter. I don't see guzzle listed as a dependency at all anymore, but I haven't built new phergie since I switched to this computer, so I cannot test this quickly.
I will test this hopefully tonight and see what is going on.