String missing colon and space in ES6 version of BAM
Closed this issue · 4 comments
For phetsims/qa#482. Katie and I weren't sure if this had anything to do with ES6, so this issue might need to be moved to a different repo.
Platform: iOS 12
ES6 - "Puntuación0":
Published - "Puntuación: 0":
In babel (vegas-strings_es.json) I'm seeing this translation:
"pattern.score.number": {
"value": "Puntuación{{score}}",
It looks like the sim's been refactored to use newer code that uses a different string.
So this seems like a sim-specific translation-specific issue.
I went through the translation files, and it appears to me that es
was the only locale with this problem. Looks like it was just a bad translation, and some refactoring of the scoreboard that occurred a while back made it appear. I went ahead and directly fixed the translation file by making the string match the one for the other string with essentially the same pattern. It looks good on master now (screenshot below), so should be fine in the next deploy. Closing.