String missing colon and space in ES6 version of BAM

Question

String missing colon and space in ES6 version of BAM

Closed this issue 5 years ago · 4 comments

For phetsims/qa#482. Katie and I weren't sure if this had anything to do with ES6, so this issue might need to be moved to a different repo.

Platform: iOS 12

ES6 - "Puntuación0":

Published - "Puntuación: 0":

Answer 1 · 2020-02-24T22:18:58.000Z

es_PE sim:

It seems this is not in every locale. Not sure what that means for the issue.

Answer 2 · 2020-02-25T20:17:13.000Z

In babel (vegas-strings_es.json) I'm seeing this translation:

  "pattern.score.number": {
    "value": "Puntuación{{score}}",

It looks like the sim's been refactored to use newer code that uses a different string.

So this seems like a sim-specific translation-specific issue.

Answer 3 · 2020-02-25T20:21:35.000Z

In that case, moving reps and assigning to @jbphet since this is his sim.

Answer 4 · 2020-02-27T00:02:30.000Z

I went through the translation files, and it appears to me that es was the only locale with this problem. Looks like it was just a bad translation, and some refactoring of the scoreboard that occurred a while back made it appear. I went ahead and directly fixed the translation file by making the string match the one for the other string with essentially the same pattern. It looks good on master now (screenshot below), so should be fine in the next deploy. Closing.