phetsims/build-an-atom

Consider converting to default layoutBounds before PhET-iO publication

Closed this issue · 1 comments

This sim currently uses non-default layoutBounds.

In BAAScreenView:

      layoutBounds: ShredConstants.LAYOUT_BOUNDS,

In ShredConstants:

  LAYOUT_BOUNDS: new Bounds2( 0, 0, 768, 464 ),

What's especially concerning here is that shred is a common-code dependency, and it's using non-default layoutBounds. See phetsims/shred#37.

Per https://github.com/phetsims/phet-io/issues/1939... layoutBounds should not be changed for published PhET-iO sims because doing so may disrupt client customizations. So evaluate whether to change layoutBounds before publishing a PhET-iO version.

If you decide not to change layoutBounds, document why, and refer to this issue.

Closing per dev meeting request 12/7/23.