phetsims/collision-lab

Inelastic screen

Closed this issue · 3 comments

brandonLi8 commented

I've already gotten a good start to the Inelastic screen in master. But there is still some design work:

  • Where will the combo box that selects different presets be located. In master, I've thrown it in a random spot.

  • What will the names be for the different presets, and what are the different presets? In master, I have 'Custom', and two temporary names.

  • What are we doing with the elasticity slider? Are we removing it or should we disable it?
    In master, it is disabled and it looks like
    image

  • What's the title string of the presets (if we need one). Currently, I have it labeled as 'Presets'
    image
    EDIT: I changed this string to 'Preset:'. But where are we placing this combo box?

  • Is there anything else in other screens that shouldn't be in this screen? (paths, values, etc.)

brandonLi8 commented

Another question. What exactly happens when the user changes a preset. Here's the current behavior (based off my solar system):

  • Pause the sim.
  • Set the elapsed time to 0.
  • Set every Ball's position, mass, and velocity to the pre-defined state, if the preset is not set to CUSTOM. Setting the preset to CUSTOM doesn't change any of the Balls.
  • If the user manipulates any of the two Balls, the preset is set to CUSTOM.
  • Setting the preset also saves the states of the Balls for the next restart press, as long as the preset isn't set to custom
brandonLi8 commented

I asked:

  • Where will the combo box that selects different presets be located. In master, I've thrown it in a random spot.
  • What will the names be for the different presets, and what are the different presets? In master, I have 'Custom', and two temporary names.
  • What's the title string of the presets (if we need one). Currently, I have it labeled as 'Presets'

In the design meeting, we decided to go with radio buttons instead. I've implemented it in master and it looks like
image

which handles the placement and removes the need for title strings, so these questions have been answered.

I also asked:

  • Is there anything else in other screens that shouldn't be in this screen? (paths, values, etc.)

Based on the design meeting, the current version of the 'Inelastic' screen looks good.

I also asked:

  • What are we doing with the elasticity slider? Are we removing it or should we disable it? ...

We decided at the design meeting to make the control panel look like

image

doing this now.

brandonLi8 commented

Done in the commit above. The control panel now looks like

image

Closing.