phetsims/collision-lab

Review ?showPointerAreas

Closed this issue · 7 comments

ariel-phet commented

@brandonLi8 it would be good to review ?showPointerAreas and likely expand a few "touch areas" where possible

For instance, the "reset collisions" button could have a dilated touch area, and I think if possible it would be good to expand the "More Data" checkbox touch area and such.

Could you take a first pass at this and then assign @arouinfar and I to review?

brandonLi8 commented

I did all of the suggestions in the commit above. Assigning @arouinfar and @ariel-phet for review.

brandonLi8 commented

Spoke with @ariel-phet on zoom. Pointer areas look good except for the number of balls number picker and the mass sliders, where this is some vertical overlap in pointer areas. Addressing that now.

  • 👍1
arouinfar commented

@brandonLi8 the pointer areas are generally looking good to me. The only device I can test touch areas on is my phone, which I can do if you publish a dev version (no VPN to access master on my phone).

ariel-phet commented

@brandonLi8 I reviewed on my phone. All looking quite good but I do have 2 requested tweaks:

  1. Increase the "reset collisions" touch area a bit more (until it touches the reflecting border)
  2. Dilate the zoom in/out button touch areas for the momentum diagram
brandonLi8 commented

Done in the commit above.

Restart Button:

image

Momenta Diagram:
image

@ariel-phet @arouinfar please review in https://phet-dev.colorado.edu/html/collision-lab/1.1.0-dev.3/phet/collision-lab_en_phet.htm

ariel-phet commented

All looks good. Closing!