phetsims/collision-lab

Should PhetColorScheme be updated?

Closed this issue · 4 comments

brandonLi8 commented

From the CRC:

  • Is PhetColorScheme used where appropriate? Verify that the sim is not inventing/creating its own colors for things that have been standardized in

I marked this as failing for now. I took a look at PhetColorScheme, and there are 3 things that could potentially be updated.

  1. According to PhetColorScheme, acceleration is green. Luckily, there are 0 usages of this! My recommendation would be to change this to yellow and update sims like projectile motion and collision lab (and others?) to use this constant.

  2. According to PhetColorScheme, velocity is red-colorblind. Luckily, there are 0 usages of this! My recommendation would be to change this to green and update sims like projectile motion and collision lab (and others?) to use this constant.

  3. There is no momentum in PhetColorScheme. We should probably add momentum using the color that collision lab is using.

@arouinfar @ariel-phet should I proceed with this?

ariel-phet commented

@brandonLi8 yes go ahead and make this change

  • 👍1
arouinfar commented

@brandonLi8 I opened an issue in scenery-phet to track these changes.

  • 👍1
jonathanolson commented

Should be good in master, @arouinfar can you verify?

arouinfar commented

Looks good in master. Thanks @jonathanolson.