Position Keypad
Closed this issue · 4 comments
From the dust-off meeting @arouinfar and I had, there were two options that were presented for positioning the keypad; either above the BallValuesPanel or to the right of the BallValuesPanel.
There wasn't a decision made, so this issue is here to track this.
Looks like there was a decision made on 9/19/2019: "Keypad will appear to the [right] of the panel, and would obscure the Momenta diagram, if open."
Doing this now.
In the commit above, I attempted to position the keypad correctly.
However, expanding more-data and popping up the dialog doesn't reposition the keypad, and only does so when you close it and resize the browser window. Making an issue in sun.
Now that phetsims/sun#600 is done, the keypad is now positioned to the right of the BallValuesPanel with the same margin for both the More Data on and off. Keep in mind the y-position of the Keypad changes based on the height of the panel (bottom aligned).
@arouinfar this is ready for review in master.
@brandonLi8 the keypad placement and alignment look really good in master. Nice work!