phetsims/forces-and-motion-basics

Add in Africa/ Modest, Asia, Oceania, and Latin America character sets

amanda-phet opened this issue · 8 comments

Add in Africa/ Modest, Asia, Oceania, and Latin America character sets

The preferences model and structure for portrayals is added in and FAMB is ready for the artwork @amanda-phet.

New USA set (in svg) is ready to try out. I gave these to @Luisav1 on slack, but will put here for posterity. If these work out, I will move ahead with exporting the other regions (which are all drawn and resized, but there will be some more steps before they are ready for export)

usaGirlHolding
usaGirlSitting
usaGirlStanding
usaManHolding
usaManSitting
usaManStanding

These are looking good!

Should we be including "Africa (modest)" in the list of regions if there isn't a separate set of people for that region?

I will ask about this in the region and culture channel!

Let's go ahead and remove Africa (Modest) from the preferences dropdown.

I removed Africa (modest) in the commit. @amanda-phet can you please review/test and summarize what changes remain for this issue?

In recent client meetings, it was again found that clients using products in particular regions value the positive affirmation that a character set is "modest". So we should keep Africa (modest) setting as an option, even if at the moment it is just a duplicate of the Africa setting.

@samreid - Can you please revert the removal of this option, Sam?

I reverted the removal and tested that it worked OK at runtime.