phetsims/neuron

StringTest=double not handled gracefully by chart title

Closed this issue · 5 comments

ariel-phet commented

The chart title overlaps with the clear button. The chart title should scale down in font size if it gets too long (perhaps if it is going to violate the space of the Clear button?

neuron

jbphet commented

Fixed in both the master and 1.0 branches by adding a maxWidth to the title and making some other adjustments. Chart for stringTest=double now looks like this:

neuron-chart-double-strings

For stringTest=long it looks as shown in the following screen capture. The Clear button is very short, but setting a min height wasn't working as expected, and the caption is ridiculously long anyway, so I don't believe that this will be a problem in the real world.

neuron-chart-long-strings

jbphet commented

Fix should appear in v1.0.0-rc.2, leaving open until verified on that release.

jbphet commented

Assigning to @ariel-phet so that he or someone on the QA team can verify that this is fixed on v1.0.0-rc.2 (http://www.colorado.edu/physics/phet/dev/html/neuron/1.0.0-rc.2/neuron_en.html).

ariel-phet commented

Made checklist item for phetsims/tasks#485

elisemorgan commented

This issue has been resolved