phetsims/neuron

sim relies on align:'right' default for Panels

Closed this issue · 1 comments

pixelzoom commented

Related to phetsims/sun#252, this sim relies on the old default of align:'right' for Panels. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM25043 Panel.js?bust=1472164970317:54 Error
    at IonsAndChannelsLegendPanel.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164970317:50:15)
    at new IonsAndChannelsLegendPanel (http://localhost/~cmalley/GitHub/neuron/js/neuron/view/controlpanel/IonsAndChannelsLegendPanel.js?bust=1472164970317:123:11)
    at new NeuronScreenView (http://localhost/~cmalley/GitHub/neuron/js/neuron/view/NeuronScreenView.js?bust=1472164970317:278:38)
    at NeuronScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/neuron/js/neuron/view/NeuronScreen.js?bust=1472164970317:35:34)
    at NeuronScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164970317:134:25)
    at NeuronScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164970317:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164970317:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164970317:439:13)
    at http://localhost/~cmalley/GitHub/neuron/js/neuron-main.js?bust=1472164970317:31:15
VM25043 Panel.js?bust=1472164970317:53 


>>>> sim relies on align:right
VM25043 Panel.js?bust=1472164970317:54 Error
    at SimSpeedControlPanel.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164970317:50:15)
    at new SimSpeedControlPanel (http://localhost/~cmalley/GitHub/neuron/js/neuron/view/controlpanel/SimSpeedControlPanel.js?bust=1472164970317:50:11)
    at new NeuronScreenView (http://localhost/~cmalley/GitHub/neuron/js/neuron/view/NeuronScreenView.js?bust=1472164970317:310:32)
    at NeuronScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/neuron/js/neuron/view/NeuronScreen.js?bust=1472164970317:35:34)
    at NeuronScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164970317:134:25)
    at NeuronScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164970317:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164970317:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164970317:439:13)
    at http://localhost/~cmalley/GitHub/neuron/js/neuron-main.js?bust=1472164970317:31:15
VM25043 Panel.js?bust=1472164970317:53 


>>>> sim relies on align:right
VM25043 Panel.js?bust=1472164970317:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164970317:50:15)
    at new MembranePotentialChart (http://localhost/~cmalley/GitHub/neuron/js/neuron/view/chart/MembranePotentialChart.js?bust=1472164970317:235:20)
    at new NeuronScreenView (http://localhost/~cmalley/GitHub/neuron/js/neuron/view/NeuronScreenView.js?bust=1472164970317:322:38)
    at NeuronScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/neuron/js/neuron/view/NeuronScreen.js?bust=1472164970317:35:34)
    at NeuronScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164970317:134:25)
    at NeuronScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164970317:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164970317:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164970317:439:13)
    at http://localhost/~cmalley/GitHub/neuron/js/neuron-main.js?bust=1472164970317:31:15
pixelzoom commented

None of the above call sites use the minWidth option, so their behavior will be unaffected. Closing.