phetsims/neuron

incorrect inherit call in MembranePotentialChart.js

Closed this issue · 2 comments

pixelzoom commented

Noted while working on phetsims/tasks#1049.

In the MembranePotentialChart.js, Node superclass constructor is call, but inherit is using Panel. Node appears to be the proper superclass.

function MembranePotentialChart( chartDimension, neuronClockModelAdapter ) {

  const self = this;
  Node.call( this );
...
}
...
inherit( Panel, MembranePotentialChart, {
pixelzoom commented

Fixed in the above commit. @jbphet please review.

jbphet commented

Looks good to me, thanks. Closing.