Delete tiltProperty?

Question

Delete tiltProperty?

Closed this issue 2 years ago · 4 comments

"Tilt" used to be an important concept in this sim, but it is not anymore and we might be able to remove this Property. Everything is now based on geometric properties like vertex angle, pairs of parallel sides, and others.

If we can, we can also delete calculateAngle in Vertex.ts which is only used to calculate the tilt for some reason.

Answer 1 · 2023-02-22T23:07:25.000Z

I don't see any usages of side.tiltProperty, nor of the saved values in ShapeSnapshot. I am going to delete this.

Answer 2 · 2023-02-22T23:08:36.000Z

All options passed to Side were related to tiltProperty so they can be removed too.

Answer 3 · 2023-02-22T23:11:45.000Z

Also, these two in the QuadrilateralDescriber are not used

    // TODO: Do we need a query parameter for this?
    // TODO: CAn tilt be removed?
    this.tiltDifferenceToleranceInterval = 0.2;
    this.lengthDifferenceToleranceInterval = 0.05;

Answer 4 · 2023-02-22T23:13:31.000Z

Nice, this cleaned up a lot of things. Changes in wip-2-22-23. Closing.