phetsims/shred

new names and symbols for elements with atomic number: 113, 115, 117 and 118

Opened this issue · 8 comments

On June 2016 IUPAC announced new symbols and names (i.e. for 113 https://www.webelements.com/nihonium/).
I've detected the issue in build an atom 1.2.5, but looking at the code the symbols should be updated in this repo, at AtomIdentifier.js, symbolTable. Those are the new lines:

    'Nh', // 113, NIHONIUM
    'Fl', // 114, FLEROVIUM
    'Mc', // 115, MOSCOVIUM
    'Lv', // 116, LIVERMORIUM
    'Ts', // 117, TENNESSINE
    'Og'  // 118, OGANESSON

Thanks @jgpATs2w. @ariel-phet could you please review and assign someone to work on this issue?

Here is a snapshot of the periodic table from v1.2.5 of BAA, which is live on the web site as of this writing:

baa-table-before

Here is what it looks like with the modifications in place:

baa-table-after

The suggested changes have been made. There is currently an RC under test for Build an Atom, it would be good to get this change into it since it may be a long time before another release is done. Assigning to @jessegreenberg to make sure that this happens.

Added to the 1.6 branch, thanks @jbphet. Closing.

I renamed the symbols, but it looks like I didn't do the element names. This isn't a big deal in the normal use of the sim because the sim never shows element names above atomic number 99. However, while working on instrumentation of the BAA game (see phetsims/build-an-atom#156), we decided to use the element name in the data stream. Now, the element name on the periodic table in the stream doesn't match the symbol used for elements 113, 115, 117 and 118. This should probably be fixed. This may a bit tricky because the key names in the strings file will need to change too, which could cause incompatibility with previous translations.

After working on this issue with @chrisklus and @jbphet, it seems like this issue is over. The keys in the shred-strings_en.json file were updated as per the suggestion of @jbphet. This means that certain translation files in babel have translations that won't actually get used (eg there is a translation defined for ununoctium, but no sim will ever ask for ununoctium because the new key is oganesson), but that should be fine, as those translations weren't in use anyways before. The new keys also apparently don't show up in Rosetta, but @jbphet said that that shouldn't be an issue for right now for the same reason. It seems like BAA and IAAM still work fine despite the new changes.