finalize placement of radio buttons in the Equation accordion box
Closed this issue · 10 comments
In #128, we decided that the location of the radio buttons in the Equation accordion box would be determined based on interviews. See that issue for discussion of pros and cons, starting at #128 (comment).
The equationButtons
query parameter takes values left
and right
(the default), which determines where the radio buttons are placed in the Equation accordion box. Here's a comparison, reproduced from #128 (comment):
With ?equationButtons=left
:
With ?equationButtons=right
(the default):
The current vote on this (as I understand it) is:
- @arouinfar - buttons on right
- @ariel-phet - whatever @arouinfar decides
- @kathy-phet - buttons on left
- @pixelzoom - buttons on left
@arouinfar - buttons on right
My opinion is a bit more nuanced. I think buttons on left looks better, but I suspect buttons on right might be preferable flow-wise if the goal is for students to experiment with the coefficients in the equation before cycling through equations.
My plan is use ?equationButtons=left
in interviews. If I notice flow issues in the first 2 interviews, I'll switch to ?equationButtons=right
in the subsequent interviews.
I'm in the process of scheduling interviews in the Oct 2-8 window. So far, I have 3 volunteers, but I'll probably have a few more volunteers by the end of the day.
My plan is use
?equationButtons=left
in interviews.
Would you like me to make that the default? The default is currently right
.
@pixelzoom I am perfectly fine with appending ?equationButtons=left
to the URL, but if you are planning on publishing a new dev version in the next day or two, please change the default to left
.
Default changed to ?equationButtons=left
in 1.0.0-dev.29.
Thanks @pixelzoom!
In the above commit, I prevented the contents of the Equation accordion box from shifting around when switching between Cartesian and Polar scenes. This change is present in 1.0.0-dev.30.
1.0.0-dev.30 has some problems related to memory management changes for #87. Please use 1.0.0-dev.31 for interviews.
I've completed 4 interviews with the equation buttons on the left and I have not seen any flow issues, so let's keep the buttons on the left. The default is currently left
but I imagine we may want to delete the query parameter, so back to @pixelzoom.
Thanks @arouinfar. equationButtons
query parameter has been removed, closing.