review pointer areas
Closed this issue · 6 comments
After the fix and tweaks for vector pointer areas in #206, pointer areas are looking good to me. Over to @arouinfar for sign-off.
@ariel-phet would like this assigned to him too.
The pointerAreas are all looking good to me @pixelzoom. I didn't have any issues with touch on the iPad. On mobile, checkboxes occasionally took an extra tap to toggle, but I think that's acceptable.
@arouinfar @pixelzoom all looking quite good, but I would suggest dilating the eraser button slightly, a bit hard for me to click on mobile. Maybe split the difference between the white space between the graph and the button for the dilation.
No need to reassign to me @pixelzoom, if you make this change, feel free to go ahead and close.
Slack:
Chris Malley 1:15 PM
Re https://github.com/phetsims/vector-addition/issues/205#issuecomment-536706598… Are you asking for touchArea dilation of the eraser button only, or also mouseArea?
Ariel Paul 1:15 PM
apologies, just touchArea
mouseArea is totally fine
In the above commit, the eraser button touchArea is dilated as requested, identical in all screens that have an eraser button. Example screenshot below.
Closing, reopen if anything appears to be amiss.
