Minor pointer area overlap
Closed this issue · 3 comments
Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
For phetsims/qa#434
Likely already discussed, and minor enough that I don't personally recommend any changes. Feel free to close after review. When a vector partially or fully covers the origin point on the graph, that point can be difficult or impossible to move without moving the vector above it. I think this is preferable to the alternative however.
Visuals
Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: Vector Addition
URL: https://phet-dev.colorado.edu/html/vector-addition/1.0.0-dev.36/phet/vector-addition_all_phet.html
Version: 1.0.0-dev.36 2019-10-03 17:23:25 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}
@ariel-phet had some strong opinions on the size of the origin manipulator and its touch area, so I'm assigning him to this issue too. For reference, our decision about the origin manipulator can be found in #176.
My recommendation is to do nothing here. If you can't grab the origin manipulator (which is clearly under the vector), then move the vector.
Thanks @KatieWoe.
If we were to dilate the touch area of the origin manipulator any further, the bounds would spill over into the neighboring grid squares, which could easily result in accidental grabs. Like @pixelzoom, I'm inclined to leave things as they are.
Agreed, I appreciate pointing out this potential issue, but I don't think it is a concern. Closing