phetsims/vector-addition

Possible slight overlap of lengthened x-axis labels

Closed this issue · 2 comments

Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
For phetsims/qa#434
When the x-axis label is translated it can slightly overlap with the control elements to the right of the graph. This can be seen very slightly with stringTest=long, but is more noticeable with rtl. Since this length of translation is unlikely to occur this can probably be closed without doing anything if you agree.
Steps to reproduce

  1. Use stringTest long or rtl
  2. Go to any screen
  3. Move the origin to move the x-axis up and down and observe overlap with tools on the right.

Visuals
longlap
moreoverlap
potentialoverlap

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Vector Addition‬
URL: https://phet-dev.colorado.edu/html/vector-addition/1.0.0-dev.36/phet/vector-addition_all_phet.html
Version: 1.0.0-dev.36 2019-10-03 17:23:25 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36
Language: en-US
Window: 1536x722
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

Looks like maxWidth for the x-axis label should be a little smaller. I'm on it.

Fixed in the above commits in master.

With no stringTest:

screenshot_1573

With ?stringTest=long:

screenshot_1572

With ?stringTest=rtl:

screenshot_1571

Closing.