phetsims/vector-addition

Larger touch area on equation spinners

Closed this issue · 5 comments

kathy-phet commented

In playing I found that it would be good if we could increase the touch area of the equation coefficients more too. It led to a bunch of mis-fires when I used it, and it seemed like it would not conflict with anything to dialate it more so similar in size to the unit vectors spinner which was easy to use.

arouinfar commented

I do not experience the same mis-fires on the equation spinners on my phone, but we certainly have plenty of space to expand them a bit more, say 25% (shown in green).
image

kathy-phet commented

Thanks!

pixelzoom commented

While we're at it... Should the base vector pickers be adjusted too? They have the same pointer areas as the coefficient pickers, see below.

screenshot_1611

pixelzoom commented

@arouinfar please review in master.

I went ahead and adjusted touchArea for the base vector pickers too. There is no room to increase their y dilation, they would overlap. So I only increased their x dilation, using the same value as for the coefficient pickers. Screenshots below show before and after.

If you want to make further tweaks, here are the current dilation values:

// coefficient pickers, EquationTypeNode.js
touchAreaXDilation: 20,
touchAreaYDilation: 14

// base vector pickers, BaseVectorsAccordionBox.js
touchAreaXDilation: 20,
touchAreaYDilation: 10

Before:

screenshot_1613

After:

screenshot_1612

arouinfar commented

Thanks @pixelzoom, looks good