Trouble with find in FF Quantum
Niroday opened this issue · 11 comments
Hello.
FF Quantum 58.0.2 (64-bit)
Vimium 1.63.1
From time to time text that i typing in / becomes allocated and the next symbol replaces everything in the / field. Looks like this: https://s13.postimg.org/5a6vwxmfb/vim.gif
Can you reliably reproduce this at all, @Niroday? In the gif, is it going to "0 Matches" or "1 Match" at the end?
@smblott-github
"No matches" after "conn" and 400 after replacing "conn" with "e".
Yes, i can reproduce.
The first thing i thought was it's for quick deleting, but replacing with the next symbol displelled my doubts.
Well, it's something related to inputElement here. But nothing there looks suspicious, to me.
Probably redundant but came here to submit the issue, also having problems with find, pretty much straight after the most recent update.
It's reliably unreliable, sometimes you can type 2 chars before it highlights the last char input and then you'll just start erasing characters as you type.
I have seen this in some pages, I have no idea on what could be causing it. This is one of them http://docs.sqlalchemy.org/en/latest/dialects/postgresql.html
Having this exact same problem as of recently with Waterfox 56.0.4.1.
Tried this myself.
It looks like, when there is no match, window.find() is finding the only match on the page, the one in the HUD. Once the text in the HUD is selected, then next key clears the input.
There seem to be other changes to the behaviour of window.find(); for example, search no longer seems to wrap.
@smblott-github I suggest that we change https://github.com/philc/vimium/blob/master/content_scripts/mode_find.coffee#L180 's second true into false (arg "aSearchInFrames"), which should be useful. In my tests, Chrome does not support this argument and always returns false if a query is not in current frame.
Refer: https://developer.mozilla.org/en-US/docs/Web/API/Window/find
Great suggestion, @gdh1995. That seems to fix it.
Fixed in 1bfe474.
I'm minded to publish this for FF as v1.63.1, v.1.63.2.