philipdelff/NMdata

Compatibility with the development version of tibble

krlmlr opened this issue · 3 comments

krlmlr commented

This package no longer passes its checks with the current tibble release candidate, perhaps triggered by tidyverse/tibble#1574 (now keeping attributes named "x" and "n" after new_tibble() and as_tibble()). Please see https://github.com/tidyverse/tibble/blob/main/revdep/problems.md#nmdata for details.

Should we be doing things differently? Can you please take a look and, if appropriate, submit an update to CRAN? Thanks!

philipdelff commented

Thank you. The test has been generalized and is no longer affected by the change in tibble. I plan to submit to CRAN within a week.

philipdelff commented

Version 0.1.6 is now on CRAN. It should work with the new version of tibble.
Thanks!

  • 👍1
krlmlr commented

Thanks, Philip, for your prompt response.