philips-software/docker-ci-scripts

Setting boolean to false will still trigger the feature

Brend-Smits opened this issue · 0 comments

When using docker-ci-scripts you can specify you sign, generate provenance or create a SBOM for the image.
You do this by adding the option:
with: sbom: true
This works, however, when you try to disable it by setting the true to false, the value is not being respected. It seems that the bash script only checks if the value is set, and not what the actual value is.

Proposal:
Add an extra check to determine if the value of the boolean is true, if it is, executes the logic, if not, skip the logic.
Will create a PR when I have some time to fix it soon.