phimage/Erik

LayoutEngine.handleLoadRequestCompletion() does not complete when testing on iOS device

Closed this issue · 3 comments

matadan commented

It seems that the loading flag is never set on iPhone (running iOS10). I think the while loop does not work as expected on an actual device.

phimage commented

thanks for your report
I have plan to change the way to detect end of loading using webkit delegate

did you use swift 3 branch? or master one

matadan commented

I’m using cocoapods but I don’t .

I have fixed it I think. But you might have a better way. I observed the “estimatedProgress” property instead of the busy while loop.

On 4 Sep 2016, at 17:47, Eric Marchand notifications@github.com wrote:

thanks for your report
I have plan to change the way to detect end of loading using webkit delegate

did you use swift 3 branch? or master one

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #15 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ABe-sPYWf10pob6mec6ulVSvFVkhc_98ks5qmvYYgaJpZM4J0gIl.

phimage commented

I will allow to choose the algo via an enum (loading, estimatedProgress, navigationDelegate)

For estimatedProgress did you test only if the value == 1
Because if the webview has been never used, and someone try to get content, the value will be 0