phntxx/dashboard

[App/Bookmark/Search] Open links in new tabs, make apps and bookmarks searchable

DeRuiterIndustrieleAutomatisering opened this issue · 3 comments

DeRuiterIndustrieleAutomatisering commented

What do I have to change to open all (apps and bookmarks) links in new tabs? (I'm just started learning React)

Can you add a button to erase the previous search statement with one click?

Do you like the idea to update the lists when typing a search statement and only show applications and bookmarks which are equal to the search?

phntxx commented

Hi!

I'll go through your questions 1 by 1:

What do I have to change to open all (apps and bookmarks) links in new tabs?

  1. This line in app.tsx would have to look like this: <AppLink href={URL} target="_blank">{name}</AppLink>
  2. This line in bookmarkGroup.tsx would have to look like this: <Bookmark key={[name, idx].join("")} href={url} target="_blank">
  3. This line in imprint.tsx would have to look like this: <Link href={field.link} target="_blank">{field.text}</Link>
  4. Bookmarks are handled through window.location.href-calls, as far as I know you can't reliably change that in a way that it opens a new tab

Can you add a button to erase the previous search statement with one click?

That sounds like a good idea that should be easy to implement. I'll add that once I get around to it.

Do you like the idea to update the lists when typing a search statement and only show applications and bookmarks which are equal to the search?

While I do like the idea, I can't tell how hard that would be to implement. I'll have a look at it.

Thank you very much for your input! :)

Kind regards
Bastian

  • 👍1
phntxx commented

Quick Update: I've added that button to erase the search statement with one click (I made it so that it appears if there's something search bar)

KillerTic commented

Could there be an option to have the search open a new tab?

  • 👍1
  • 👀1