Selected items are black in nemo

Question

Selected items are black in nemo

snakedye opened this issue 4 years ago · 14 comments

selected:

unselected:

This affect icons as well as the text on the sidebar.

Answer 1 · 2021-02-08T11:32:06.000Z

@snakedye So the sidebar is a normal GTK3 list widget, and the icons just take the same color as the text. I found that the elementary GTK theme does some stuff to color those icons separately (which i like), but i haven't looked it up in their code yet.

The main view on the other hand is a different story. It is a custom widget and i have no clue how it is styled. So if you have any information on this, i would appreciate it.

Also the styles for this will most likely be added as application specific styles, so they don't affect any other apps.

Answer 2 · 2021-02-08T12:02:13.000Z

Thanks, I will look into this and hopefully come back with a PR.

Answer 3 · 2021-02-08T12:56:46.000Z

No need for a pr, some information would be enough.

Answer 4 · 2021-02-09T04:18:05.000Z

https://github.com/horst3180/arc-theme/blob/8290cb813f157a22e64ae58ac3dfb5983b0416e6/common/gtk-3.0/3.16/sass/_transparent_widgets.scss

Answer 5 · 2021-03-25T17:18:27.000Z

  &:selected {
    background: $accent-7;
    color: $background-2;
  }

Changing this in /scss/components/_treeview.css yields this result.

Answer 6 · 2021-05-10T11:09:00.000Z

Something similar with selection in address bar in thunar, vivaldi, firefox, etc. can't distinguish between selected and not selected texts in the address bar .
These ones have selected texts:

and these are not selected.

Answer 7 · 2021-05-10T11:18:54.000Z

@obliviousofcraps it looks like you are running an old version of phocus, or you restyled it in a way in which this is caused. Current phocus has bright purple selections everywhere:

There has been a lot of changes lately, so maybe you just didn't update in a while.

Edit: and the issue with the selected files in the file-view will be resolved in the near future.

Answer 8 · 2021-05-10T12:31:34.000Z

Okay, i'mma try and will let you know how it goes.

Also which property do I need to play with to change the colors for that?

Answer 9 · 2021-05-10T13:02:12.000Z

@obliviousofcraps currently it is the $primary-accent in https://github.com/phocus/gtk/blob/master/scss/gtk-3.0/_colors.scss#L16.
GTK3 phocus does not have a stable release yet (https://github.com/phocus/gtk/releases), which means this can change at any second, since i develop against the master branch, and i am still planning to restructure the options and colors to make it easier customizable, especially when there are dark and light variations and gtk3 plus gtk4 versions. (GTK2 will never be supported btw)

Answer 10 · 2022-04-09T17:10:42.000Z

@snakedye i added some exceptions for nemo in the latest commits, it should look fine now:

Answer 11 · 2022-04-09T17:13:05.000Z

The latest nautilus update is also themed properly. Just a shame that the new adwaita folder icons look so horrible:

Answer 12 · 2022-04-09T18:26:22.000Z

Eagerly waiting for philes and it's beautiful icons.

Answer 13 · 2022-04-09T18:51:04.000Z

@snakedye not gonna happen, but here is a screenshot of what pholders could have become if I would not have much more interesting things to work on:

Answer 14 · 2022-04-09T22:44:29.000Z

Really nice, it has the flat style of Papirus which I'm currently using. I found it weird Adwaita doesn't have flat icons when the whole theme is now flat.