Should `esbuild.install --if-missing` check also if outdated

Question

Should `esbuild.install --if-missing` check also if outdated

Closed this issue 3 years ago · 6 comments

cw789 commented 3 years ago

Or should I add a --update-only flag?

What do you thing?

Answer 1 · 2021-08-28T10:20:31.000Z

Checking the version is a good idea. Can you please send a PR?

Answer 2 · 2021-08-28T12:26:14.000Z

I had some free time and I will push it. :)

Answer 3 · 2021-08-28T12:30:48.000Z

Ohh, my PR is up. By checking Esbuild.configured_version() we will unexpectedly update for users if the latest_known version within esbuild is updated and no version is configured.

Answer 4 · 2021-08-28T12:32:57.000Z

@cw789 I think that behaviour is the desired one, after all, esbuild is under a lock file too. Otherwise people on the same esbuild version will get different outputs depending if they ran mix esbuild.install in a previous version, no?

Answer 5 · 2021-08-28T12:40:40.000Z

You're right. Got my head around. Thanks for learning.

Answer 6 · 2021-08-28T12:43:06.000Z

Thank you for double checking and once again, sorry for the double effort. :)