The latest version increase the app size to almost double
iamromec opened this issue · 2 comments
iamromec commented
Expected Behaviour
It should just upgrade to the latest version
Actual Behaviour
It increases the size of my Ionic app from 5.2M to 8.4m
Reproduce Scenario (including but not limited to)
- Check the size of APK with old plugin
- Remove the old 2.2.3 plugin and reinstall it
- Now go back check the size of the latest build, you'll see a huge difference and also it reduces the speed
Steps to Reproduce
- Above mentioned
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Ionic 4, Cordova 9.0.0
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Cordova CLI version and cordova platform version
cordova --version # e.g. 6.0.0
cordova platform version android # e.g. 4.1.1
Plugin version
cordova plugin version | grep phonegap-plugin-push # e.g. 1.5.3
Sample Push Data Payload
Sample Code that illustrates the problem
Logs taken while reproducing problem
dplewis commented
@iamromec regardless of performance or size does this fix your deviceToken issue? If it does then your solution for decoding is in this code.
If not open a new issue. I’m sure somebody has or had the issue you are having.
pkdetlefsen commented
I thought I was having this issue as well because I had just upgraded the plugin and experienced longer startup times and a much large app size. However, it turned out that I had just forgotten to use the --prod flag for production build when building the app with cordova build ios.
When using cordova build ios --prod I don't experience those issues.