Pin to git tag for phovea dependencies, or find a different approach
mccalluc opened this issue · 2 comments
mccalluc commented
We need to pin our phovea references, but it's not working right now: #16 (comment). Why?
If we can't figure this out, maybe just use npm?
sgratzl commented
https://github.com/phovea/phovea_d3/blob/v0.0.1/package.json -> links to phovea_core master
phovea_d3 -> links to v0.0.1
since it is stated to match the exact version, npm correctly checkouts two different versions, master branch for phovea_d3 and v0.0.1 for phovea_d3. That results that the "same" core code but with different definitions should be compiled together.
solution: phovea_d3 should also use the tagged version of the master