[Symfony 4.3] Update EventDispatcher

Question

[Symfony 4.3] Update EventDispatcher

ruudk opened this issue 6 years ago · 5 comments

https://symfony.com/blog/new-in-symfony-4-3-simpler-event-dispatching

Answer 1 · 2019-06-03T15:10:19.000Z

can we do that while keeping BC for users of this bundle and staying compatible with symfony 4.2? or is this a future task for when we move to symfony 5 support?

the parameter reordering only works with 4.3+, and changing our event names is a BC break for consumers of the bundle. are there other changes that we can already do now?

Answer 2 · 2019-06-04T09:50:54.000Z

I have no idea how to handle this. Can't we detect the version of event-dispatcher that is installed?

Answer 3 · 2019-06-04T09:52:24.000Z

Maybe we can use the LegacyEventDispatcherProxy https://symfony.com/blog/new-in-symfony-4-3-simpler-event-dispatching#supporting-both-dispatchers

Answer 4 · 2019-06-04T09:56:39.000Z

I wonder if we even have to change anything, and can just allow Symfony / Event Dispatcher 4.3? I don't see any call to dispatch in the codebase.

Answer 5 · 2019-06-04T11:19:10.000Z

there is one call in a test that i fixed with a version compare in #340 . i think that should actually solve this warning. please reopen if you encounter it still with current master.