Incompatibility with php-http/curl-client 2.x

Question

Incompatibility with php-http/curl-client 2.x

deguif opened this issue 6 years ago · 6 comments

Q	A
Bug?	yes
Version	1.15.2

Actual Behavior

Not compatible with php-http/curl-client 2.0 as the Curl client expects a Psr\Http\Message\ResponseFactoryInterface and a Psr\Http\Message\StreamFactoryInterface arguments, but the CurlFactory instantiates the curl client with a Http\Message\MessageFactory and a Http\Message\StreamFactory.

Possible Solutions

Change the type-hint in the curl factory but this would probably be a BC break.

Answer 1 · 2019-06-03T15:43:50.000Z

thanks, yep we are aware of this issue. for now, you can restrict the curl client to 1.* to avoid the issue. somebody is looking at doing a pull request to support curl-client 2.*.

Answer 2 · 2019-06-03T15:58:36.000Z

Thanks @dbu for the info and sorry for the noise.

Answer 3 · 2019-06-03T16:09:18.000Z

no worries, thanks for reporting the issue. it was not visible in github that we are aware of the problem, no mistake from you at all, on the contrary, glad when people report issues so we are aware of them ;-)

Answer 4 · 2019-06-05T11:33:22.000Z

Thanks @dbu
Will a new release be published?

Answer 5 · 2019-06-05T11:56:58.000Z

yes, sure. i am preparing the release now.

Answer 6 · 2019-06-05T12:37:18.000Z

Thanks again @dbu for the release