[0.5.0] Array Syntax

Question

[0.5.0] Array Syntax

Closed this issue 6 years ago · 5 comments

The following is accepted by the parser: array<string,float>, but this is not: array<string, float>. Is that intentional?

RuntimeException: A type is missing in a collection expression

phpdocumentor/type-resolver/src/TypeResolver.php:240
phpdocumentor/type-resolver/src/TypeResolver.php:448
phpdocumentor/type-resolver/src/TypeResolver.php:204
phpdocumentor/type-resolver/src/TypeResolver.php:126

Answer 1 · 2017-12-28T21:44:09.000Z

I did't think about that case, I think it should be possible to add that to the tokenizer. But I think it MUST only contain 1 space, multiple should result in an error.

Answer 2 · 2017-12-29T23:32:33.000Z

Do you want to implement this, or shall I? I don't want us both to implement it at the same time you see. :)

Answer 3 · 2017-12-30T07:26:04.000Z

Pr is much appreciated. Didn't have time to get in to this

Answer 4 · 2018-08-09T15:05:32.000Z

@jaapio so you're thinking the only allowed variation from array<string,float> is just the single space after the comma, array<string, float>... no other extra spacing is allowed... right?

Answer 5 · 2018-08-09T15:07:03.000Z

@ashnazg correct, it doesn't make sense.