phpbb-extensions/ad-management

Centering issues again

iMattPro opened this issue · 3 comments

@senky @Derky

Since we added an inner div to our ad templates, we have centering issues again.

This time the issue affects users who want to add like an Advertisement heading to their ads.

screen shot 2017-06-16 at 2 14 58 pm

We can make our inner div have a width of 100%. But that introduces a new problem, because the flex-box is centering the inner div, which would now be full width, so any ad codes inside will be left justified again.

screen shot 2017-06-16 at 2 51 26 pm

This then forces the user to find their own way to center the ad in their ad code.

Basically what we need is full width support of the page (i.e.: the parent div the ad is in) and the ad needs to be centered, without applying any of its formatting to the internals of the ad itself.

Derky commented

Besides your fix we could also decide to just remove the text-alignment so the admin can add it's own CSS and is not forced to have it center.

I'd rather it be centered by default, and only make the user add extra css if they want to do something more than just the simple default behavior or centering.

Derky commented

Ok yeah I guess you can just do a float:left if you want to overwrite it.