What is this code?
iMattPro opened this issue · 0 comments
iMattPro commented
I don't understand what the point of this code is, in the prepare_ad_owner function:
if (empty($user_name))
{
return $user_id[0];
}
It's not able to be reached in our tests, and I can't figure out under what cases this would be needed nor can I tell if what it's returning is even correct?
Also wouldn't it be better to just use user_loader->get_username()
instead of this awkward user_get_id_name()
function throughout this extension?