phpmyadmin/website

Download links should escape plus sign

Opened this issue · 5 comments

ibennetch commented

When generating the links to download a snapshot, such as file phpMyAdmin-6.0+snapshot-all-languages.zip, the plus sign should technically be URL encoded to %2b.

This isn't usually a problem that I've seen, but there is something going on with our CDN that causes downloads to fail verification. Our CDN provider is looking at whether there is something they should do to fix it, but according to (my understanding of) the standards we should also encode the plus sign here.

ibennetch commented

This is directly related to #164.

ibennetch commented

I may be mistaken on this, according to https://stackoverflow.com/a/2678602/2385479 it appears to me the plus sign is literal in a URL except when part of a query string. So I think our code and URL is technically correct.

We are still discussing it with the CDN provider.

  • 👍1
liviuconcioiu commented

According to RFC1738, plus sign is allowed in the URL - https://datatracker.ietf.org/doc/html/rfc1738#section-2.1.
According to RFC1630, plus sign should be encoded if it's in the query string - https://datatracker.ietf.org/doc/html/rfc1630

So, clearly the issue is on their side.

  • 👍1
MauricioFauth commented

@ibennetch Could we encoded the URL to encode the plus sign to %2B as a temporary fix?

williamdes commented

So, clearly the issue is on their side.

Thank you for the RFC links.

I sent an email expressing our dissatisfaction about they reply.

  • 👍1