Bad perf impact for the bootstrap.php file

Question

Bad perf impact for the bootstrap.php file

romainneutron opened this issue 7 years ago · 9 comments

Since #16, when running a project that has phpstan/phpstan-shim in its dependencies, the bootstrap.php is called and loads the shim dependencies.

I'm not sure this is expected.

More over, loading over a phar is quite slow and has a significative performance impact (between 10ms and 25ms on an SymfonyCloud server).

Why did you do that? Is there a way to fix this perf issue?

NB : Yes, I know it's a dev dependency, however I would like to be able to run my project with dev dependencies installed without a perf impact - at least not a such big impact.

Answer 1 · 2019-04-30T12:47:39.000Z

Hi, what dev dependendency are you running so often that you’re noticing 15 ms? Why do you have installed dev dependencies? This is a won’tfix most probably, can’t do anything about it. You might figure out a way how to do lazy-loading so I’m interested to hear it.

On Tue, 30 Apr 2019 at 04:44, Romain Neutron ***@***.***> wrote: Since #16 <#16>, when running a project that has phpstan/phpstan-shim in its dependencies, the bootstrap.php is called and loads the shim dependencies. I'm not sure this is expected. More over, loading over a phar is quite slow and has a significative performance impact (between 10ms and 25ms on an SymfonyCloud server). Why did you do that? Is there a way to fix this perf issue? NB : Yes, I know it's a dev dependency, however I would like to be able to run my project with dev dependencies installed without a perf impact - at least not a such big impact. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#26>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZTOCKJQJBD2SCYPKBITDPTAIGJANCNFSM4HJKA3PQ> .

-- Ondřej Mirtes

Answer 2 · 2019-04-30T13:33:24.000Z

@ondrejmirtes The issue is that, PHP needs to unzip the phar archive for every request. That's both IO and CPU intensive.

Answer 3 · 2019-04-30T14:09:03.000Z

But it's a dev dependency, it shouldn't matter.

Answer 4 · 2019-04-30T14:09:34.000Z

Sure, your local environment will be slower but I can't imagine any real world impact from this.

Answer 5 · 2019-04-30T15:01:34.000Z

People often install dev-dependency on production. It's actually quite dangerous to NOT install dev dependency on production because most applications do not have tests which checks that the application works without dev-dependecies.

Answer 6 · 2019-04-30T15:04:11.000Z

That’s horrible. For example having PHPUnit in production is active security risk.

On Tue, 30 Apr 2019 at 10:01, Jan Tvrdík ***@***.***> wrote: People often install dev-dependency on production. It's actually quite dangerous to NOT install dev dependency on production because most applications do not have tests which checks that the application works without dev-dependecies. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZTOAFXE3U7VFJFKDFCVTPTBNM5ANCNFSM4HJKA3PQ> .

-- Ondřej Mirtes

Answer 7 · 2019-04-30T15:53:52.000Z

Reading the Phar file when initializing the autoloader is consuming 15ms @ondrejmirtes

When deploying on SymfonyCloud, dependencies are installed with dev dependencies for instance.
And it may happen for some reason.
However, this should not be the point, let's not mix point of views and issues.

The issue I'm mentioning here is a perf issue.

As you said:

But it's a dev dependency, it shouldn't matter.

However, the issue is that installing phpstan/phpstan-shim adds an overhead by adding CPU usage when autoloader instantiates.

Answer 8 · 2019-04-30T16:18:03.000Z

Dev dependencies are running in CI. The build time is usually measured in minutes, or dozens of seconds in minimum. I don’t see an issue in 15 ms. You’re welcome to try to solve it - the bootstrap could have a custom autoloader that loads lazily when a class from inside is requested, but I don’t want to fix it myself.

On Tue, 30 Apr 2019 at 10:53, Romain Neutron ***@***.***> wrote: Reading the Phar file when initializing the autoloader is consuming 15ms @ondrejmirtes <https://github.com/ondrejmirtes> When deploying on SymfonyCloud, dependencies are installed with dev dependencies for instance. And it may happen for some reason. However, this should not be the point, let's not mix point of views and issues. The issue I'm mentioning here is a perf issue. As you said: But it's a dev dependency, it shouldn't matter. However, the issue is that installing phpstan/phpstan-shim adds an overhead by adding CPU usage when autoloader instantiates. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZTOENKUPBX6I7VYN3KI3PTBTRBANCNFSM4HJKA3PQ> .

-- Ondřej Mirtes

Answer 9 · 2019-10-28T17:09:04.000Z

Please try current dev-master. 10caff5