v8::Proxy API has changed (V8 6.5.164)
AlexMasterov opened this issue ยท 6 comments
AlexMasterov commented
Hello! ๐ถ
v8/v8@5b9adad ([[proxy] Set [[ProxyTarget]] to null during)
In file included from /tmp/php-v8/src/php_v8_startup_data.h:24:0,
from /tmp/php-v8/src/php_v8_isolate.h:18,
from /tmp/php-v8/src/php_v8_context.h:18,
from /tmp/php-v8/src/php_v8_exceptions.h:16,
from /tmp/php-v8/src/php_v8_value.h:18,
from /tmp/php-v8/src/php_v8_proxy.h:16,
from /tmp/php-v8/src/php_v8_proxy.cc:17:
/usr/local/v8/include/v8.h: In instantiation of 'v8::Local<T>::Local(v8::Local<S>) [with S = v8::Value; T = v8::Object]':
/tmp/php-v8/src/php_v8_proxy.cc:70:104: required from here
/usr/local/v8/include/v8.h:167:37: error: invalid conversion from 'v8::Value*' to 'v8::Object*' [-fpermissive]
*(static_cast<T* volatile*>(0)) = static_cast<S*>(0); \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
/usr/local/v8/include/v8.h:213:5: note: in expansion of macro 'TYPE_CHECK'
TYPE_CHECK(T, S);
^~~~~~~~~~
pinepain commented
@AlexMasterov hi, thanks for reporting. Could you also mention what the step to reproduce the issue? Is it an output in one of tests or you have some crafted script to trigger such output?
AlexMasterov commented
@pinepain just try to compile with the V8 version 6.5.164+, it stops at this error.
pinepain commented
Oh, I see, make sense ๐. I'll bump v8 min version this week, probably to 6.6.x.
AlexMasterov commented
Thanks for the fix and new release ๐