phronmophobic/membrane

Docstring for make-app is wrong?

hoclun-rigsep opened this issue · 2 comments

hoclun-rigsep commented

https://github.com/phronmophobic/membrane/blob/5e07b0dacffb162ba1af8640adf2e4339c63555a/src/membrane/component.cljc#L1459C1-L1503C18

  return value: the state atom used by the ui."

but it actually returns

(fn
                     ([]
                      (assoc top-ui
                             :state @state-atom
                             ::basis (::basis @component-cache)))
                     ([container-info]
                      (assoc top-ui
                             :state
                             (assoc-in @state-atom
                                       [::context :membrane.stretch/container-size]
                                       (:container-size container-info))
                             ::basis (::basis @component-cache))))

Do you want me to pr a new docstring?

phronmophobic commented

Yea, that doc string isn't right. I'll fix it. Thanks for the report!