Test function shouldn't be available in normal configuration
ZerothLaw opened this issue · 6 comments
Line 63 in cf5ff3c
A test function like this should have #[cfg(test)] set on it - it shouldn't be usable from normal configurations.
This is fixed in feature/shared-memory
Just reviewing the main branch. Also found this:
https://github.com/pi-hole/api/blob/master/src/ftl.rs#L36
Ah, I see already found and fixed in that branch.
If you'd like, I'll review that branch instead?
Yes, that branch is the latest code and will be merged into development once it is complete. It's a large change (shared memory), so it is living in that branch instead of development for now.
Thank you for reviewing the code though! It has been a journey getting this API to a state where it can be shared with the community.
Happy to help. It's a cool project and I totally understand that,