Document hidden PIHOLE_SELINUX variable
jb044 opened this issue · 1 comments
In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}
- I have read and understood the contributors guide.
- The issue I am reporting can be replicated.
- The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).
How familiar are you with the the source code relevant to this issue?:
{Replace this with a number from 1 to 10. 1 being not familiar, and 10 being very familiar}
7
Expected behaviour:
{A detailed description of what you expect to see}
pihole update code for 5 release checks for SELinux and exits if it is enabled, however there is also a shell variable PIHOLE_SELINUX. If this is set pihole -up continues with SELinux either enabled or enabled and in enforcing mode. I understand there are issues with pihole as is with SELinux and have taken measures to let it function with SELinux enforcing to a degree I can live with.
IMHO this variable should be either mentioned by the installer in update mode or documented. I just stumbled upon it in your source code.
Actual behaviour:
pihole -up on 4->5 updates pihole and the webinterface but not FTL, and thus breaks itself.
{A detailed description and/or screenshots of what you do see}
Steps to reproduce:
pihole -up on any system with SELinux enabled.
{Detailed steps of how we can reproduce this}
export PIHOLE_SELINUX=true
pihole -up
Succes
pihole -up
Failure
Debug token provided by uploading pihole -d log:
{Alphanumeric token}
Troubleshooting undertaken, and/or other relevant information:
{Steps of what you have done to fix this}
- You must follow the template instructions. Failure to do so will result in your issue being closed.
- Please submit any feature requests here, so it is votable and trackable by the community.
- Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.
- Detail helps us understand and resolve an issue quicker, but please ensure it's relevant.
- This template was created based on the work of
udemy-dl.