pi-hole/pi-hole

Teleporter has backup issues with more than 256 characters

vx400 opened this issue · 4 comments

Versions

  • Pi-hole: 5.17.2
  • AdminLTE: 5.23
  • FTL: 5.21

Platform

  • OS and version: raspbian bookworm 12 (latest), Ubuntu 22.04.3 LTS
  • Platform: Raspberry Pi 3b+, HyperV (Ubuntu)

Expected behavior

teleporter should manage more than 256 character per entry

Actual behavior / bug

I have a regex blacklist entry with more than 256 characters (~450, a lot of domains I want to accept). After backup the configs via teleporter and restore them, there is missing my long regex entry without error message. The teleporter cannot handle more than 256 character per domain entry. I think the "backup file" is correct, I didn't see any differences in the blacklist.regex.json with a long and short entry. It must me a bug in the "restore" function.

Steps to reproduce

Steps to reproduce the behavior:

  1. create under "Domains" a new regex blacklist entry with (^|\.)(de|com|dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd)$;invert

  2. maka a backup via teleporter

  3. delete the entry in "Domains"

  4. restore your configs from backup

  5. summarize of restored blacklist regtex is wrong (1 missing)

  6. check "Domains" and see there is no entry

I've added my blacklist.regex.json test file. You can replace them in your pi-hole-raspberrypi-teleporter_xxxx-xx-xx_xx-xx-xx.tar.gz\pi-hole-raspberrypi-teleporter_xxxx-xx-xx_xx-xx-xx.tar with 7-zip and re-save it to the archive to select it in teleporter.

Debug Token

blacklist.regex.json

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.