Local DNS records and CNAME don't show pagination buttons
yubiuser opened this issue · 11 comments
As per title.
NOTE:
It also doesn't show buttons for bulk deletion:
I also think the columns are too narrow and the side-by-side tables doesn't look good in boxed layout:
I think most fields are mandatory, but the page is accepting incomplete entries (without domain, IP, target, etc).
This will be tricky, so far we have relied on dnsmasq validating this input. But it seems it gracefully ignores local DNS records which are only partial and also accepts useless combinations like in your screenshot (right side) leading to config options
cname=x,
cname=,ffff
I think we will have to add some method to attach individual "validators".
The pagination and the search box don't align well (pagination a bit shorter)
On mobile it looks even worse I think
I will take a look.
Note:
On mobile, this is center aligned and there is nothing we can do because each line has a different width (this is the same in v5).
Ok.
As I said a few comments above, the columns are too narrow to show the tables.
There is not enough space for both tables, side-by-side:
Even if I change the column grid sizes from (6 - 6) to (5 - 7) there is an overlap:
I think we need a layout with one table above the other, at least for layout-boxed and mid/small screens.
I think we will have to add some method to attach individual "validators".
Fixed with #2859 and #2864. Improved by pi-hole/FTL#1773