pi-hole/web

Update Gravity page is redirect depending on the settings level

rdwebdesign opened this issue · 1 comments

rdwebdesign commented

Versions

Current development-v6 branch

Bug description

After #2882 the Tools > Update Gravity page is automatically redirected to Settings page.

This is happening because the function applyExpertSettings() is triggering a redirect if there are no visible .box elements on the page.

The real issue is:
this should be triggered only inside Settings pages, not in Tools (or any other page).

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to any Settings page and select BASIC level.
  2. Go to Tools > Update Gravity
  3. The page will be automatically redirected (but it shouldn't be).

Additional context

Reported on Discourse:
https://discourse.pi-hole.net/t/update-gravity-website-broken-reproducable-and-possible-solution-found

rdwebdesign commented

Fixed by #2993