pi-hole/web

"Settings" -> "System" -> "Restart DNS resolver": Small formatting issue

Closed this issue · 5 comments

Versions

  • Pi-hole: v5.18.3
  • AdminLTE: v5.25.2
  • FTL: v5.21

Platform

  • OS and version: Raspberry Pi OS Lite (64-bit), Bookworm
  • Platform: Raspberry Pi

Expected behavior

The same formatting scheme as the other 5 "System" settings.

Orange buttons to orange Yes buttons.
Red buttons to red Yes buttons.

Actual behavior / bug

Orange button to red Yes button does not correspond to the intended logic in my opinion :).

Steps to reproduce

Imo not necessary

Debug Token

...

Screenshots

Screenshot 2024-08-17 125455

Screenshot 2024-08-17 125915

Screenshot 2024-08-17 125937

Screenshot 2024-08-17 130051 - m

Screenshot 2024-08-17 130130

Screenshot 2024-08-17 130242

Screenshot 2024-08-17 130313

Additional context

N/A

Screenshots added.

Thanks for the report. The issue persist even on v6 for the resolver restart and flushing the network table.

Hey team, I am big fan of the project and looking to contribute. Can someone give me some context as to what the issue is. Is it the colour of the button ?

This issue is relate to the difference between the color of the "Restart DNS resolver" button:
image

and the color of the confirmation button, inside the modal window:
image

The other buttons use the same color for both buttons, but this one is using different colors.


To be honest, I think the colors were initially select (a long long time ago) to differentiate between options considered very danger/irreversible (red) or not (yellow), but the original buttons were replaced a few times and the colors remained.

Currently the colors are not very tight related to the meaning of the buttons. Also, some buttons were already changed again in Pi-hole v6.

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.