picocms/Pico

Wrong config keys in `discoverPageSiblings`

zeleznypa opened this issue · 1 comments

zeleznypa commented

Rest of the code use pages_order and pages_order_by keys.

Pico/lib/Pico.php

Line 1889 in 09aa825

if (($this->getConfig('order_by') === 'date') && ($this->getConfig('order') === 'desc')) {

PhrozenByte commented

Good catch! 👍 A pull request on the pico-3.0 branch (even though it's clearly a bug, it still is a breaking change: people likely circumvented it by other means already) is very welcome.

  • 👍1