picturepan2/devices.css

Buttons that are supposed to change color in the demo don't function.

Opened this issue · 3 comments

jmo84 commented

On the demo pages , the buttons that are supposed to change a device's color do not function. I see a tooltip telling me the CSS class but nothing else happens.

Tested in Chrome, Edge, and Firefox on desktop, Chrome on Android.

Also, there's a warning in the console about using document.write

+1 to this question, do you happen to know how to change the device's theme?

If I see this correctly, there is no JS in the code that makes switching possible. I think only the classes that can be used to change the design of the device are displayed here.

I also get a JS error, but this comes from the plugin "axe DevTools - Web Accessibility Testing". In incognito mode I don't get any JS errors.

Even though it's possible to only use CSS for something like this, this project's demo page apparently relies on JavaScript and the necessary DOM elements aren't getting their CSS class list modified by JS code.

I see tooltips that suggest what CSS class should be applied upon clicking the button, but clicking doesn't have any effect on the current document. The name I see in a tooltip should be applied to the device's representation in the DOM, but instead nothing happens.