pikvm/pikvm

Burnt colors for h.264

premekj opened this issue · 8 comments

premekj commented

Describe the bug
Colors of the h.264 stream looks too bright.

To Reproduce
clean installation (i have also tried some modifications in override.yaml but without success)
latest RPI4 with CSI bridge
H.264 stream has more brighter colors than MJPEG and real picture on monitor, tested web interface and vnc

Expected behavior
Same colors for h.264 as well

Screenshots
h264_vs_mjpeg
for example, see the difference around mouse pointer - background of the button
"Add Calendar" blends in with the surroundings. Or "Sun 12" column is white, not light gray.

Desktop (please complete the following information):

  • OS: Windows 10 (and tested on Win11)
  • Browser: latest chrome & firefox
  • VNC client: tested TigerVNC (it used h.264) with same symptoms, TurboVNC (tight encoding) is correct
  • local gigabit network without firewall

PiKVM info:

  • RPi 4
  • v2-hdmi
  • CSI bridge (tried two different)
  • KVMD version: 4.2-1
  • uStreamer version: 6.11-2
  • Linux kernel: Linux pikvm 6.6.21-4-rpi # 1 SMP Wed Mar 13 20:36:42 UTC 2024 armv7l GNU/Linux
mdevaev commented

Try to update EDID: kvmd-edidconf --import-preset=v2 and reboot.

premekj commented 
[root@pikvm ~]# rw
+ mount -o remount,rw /
+ mount -o remount,rw /boot
+ set +x
=== PiKVM is in Read-Write mode ===
[root@pikvm ~]# kvmd-edidconf --import-preset=v2
Manufacturer ID: LNX
Product ID:      0x7770 (30576)
Serial number:   0x01010101 (16843009)
Monitor name:    PiKVM
Monitor serial:  CAFEBABE
Audio:           no
[root@pikvm ~]# reboot

done, but without any change in picture

mdevaev commented

What changes did you make in configs and image?

The colors should be good unless you've tried using hdmi passthrough.

premekj commented

In the past few days I have some time to experiment with it. The problem occours only with signal from Dell docking station (TB16), used setup: notebook -> (usb-c cable) -> dock Dell TB16 -> (hdmi cable) -> CSI bridge. I have tested several different notebooks (Dell, HP and one HP desktop) with this setup, the colors were never right.

But with direct connections notebook (or any other hdmi source) -> (hdmi) -> CSI bridge working well with H.264

I have tried on clean PiKVM image:

  • change hdmi cable, csi bridge
  • switch resolution and refresh rate on notebook(s)
  • change EDID
  • H.264 kbps & gop

Is it possible to force TigerVNC viewer to use Tight compression? I have tried to set Tight compression for TigetVNC, but it always use H.264. Do you think, is it a bug in TigerVNC?

mdevaev commented

TigerVNC is always prefering H.264 because it provides better compression.

I suppose the key problem is USB-C converter.

premekj commented

I updated the firmware in dock to the latest, but the problem still persist.
I will try another docks in the next few days and I'll let you know.

I'm currently using TigerVNC 1.12.0 (it lacks h.264 support) and it is ok. Is it possible to turn off H.264 support for VNC on PiKVM in the settings?

mdevaev commented

Add this to /etc/kvmd/override.yaml to disable H.264:

vnc:
    memsink:
        h264:
            sink: ""