form.on('part', ...) add remember to add part.on('error', ...) for each part

Question

form.on('part', ...) add remember to add part.on('error', ...) for each part

Closed this issue 8 years ago · 4 comments

In the example with form.on('part', ...) it would be good to add to the docs that it's good to add a part.on('error', ...) for each part. If you dont want to risk EPIPE uncaught exceptions.

I was fighting with some edge cases and discovered this.

Answer 1 · 2017-03-28T23:14:37.000Z

The docs already mention this multiple times, like

part emits 'error' events! Make sure you handle them.

Can you make a PR for how to improve the docs that would satisfy you? I really don't understand how many times it has to be stated to be enough, and I thought writing it several times would be enough, but I guess not. I'm at a loss of how many more times to add it and where, so a PR would be the best way to help me understand what is necessary.

Answer 2 · 2017-03-28T23:22:34.000Z

Oops, I was looking for it in the comments in the code under the form.parse(request, [cb]) heading

Answer 3 · 2017-03-28T23:24:43.000Z

Or maybe even add on error handlers in the example code.

Answer 4 · 2017-03-28T23:26:39.000Z

Oh it's there. I'm on a roll of not paying attention it seems. Sorry.