pimcore/admin-ui-classic-bundle

"Save and Publish" asset button does not work correctly

Closed this issue · 0 comments

Since commited PR: https://github.com/pimcore/admin-ui-classic-bundle/pull/483/files

Saving asset does not work.

Commit in PR introduces check:

    if (task && params) {
        params.task = task;
    } else {
        this.tab.unmask();
        return;
    }

In case of default split button handler this conditional will always be false (method's task parameter is undefined), which will result in calling else code, which stops any save.

This behaviour is visible also on demo:

https://demo.pimcore.fun/admin/

Just click "Save and Publish" on any asset there.

Note that save method is binded to ExtJS handlers and not only called manually, which pass only two arguments:

this.toolbarButtons.publish = Ext.create("Ext.button.Split", {