pimlie/nuxt-rfg-icon

conflict with nuxt manifest

Opened this issue · 2 comments

brendan1212 commented

Hi,

I noticed the "Add to home screen" modal wasn't showing for my app in Chrome, and checked it out.

Chrome PWA Audit is showing 2 errors: it can't find name or short_name in manifest.
So in nuxt.config I disabled the plugin by commenting out 'nuxt-rfg-icon' in modules, and the 'rfg-icon': { ... } section, and redeployed. The "Add to home screen" modal is back and working, and the audit passed at 100%.

I found that explicitly adding @nuxtjs/manifest to modules didn't make a difference when attempting to re-enable the plugin.

However, explicitly adding a manifest section with name & short_name to nuxt.config did indeed override the issue and everything is working fine this way.

Just thought I'd give a heads up since there seems to be an issue with overwriting. Maybe with a recent nuxt-update? I'm running v2.7.1.

Cheers : )

pimlie commented

Thanks, have you seen the official nuxt pwa-module? Might be a better module to use then this one if you need a PWA, it also includes an icon module. Only doesnt seem to provide a browserconfig.xml :)

brendan1212 commented

Found that recently! I'll be switching over once their v3 is out of beta. In the meantime, I'm wondering if there's an easy way to disable the warning, "plugin is disabled in dev mode". ?